GS/HW: Extend blend second pass to more blend formulas. #11113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GS
GS: Hardware
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
labels
|
Metal Gear Solid 3 still has black spots in the forest with DX11 and DX12 on Basic and any other blending level. |
lightningterror
force-pushed
the
gs_extend_blend_pass2
branch
3 times, most recently
from
5708ed7 to
1a41518
Compare
JordanTheToaster
approved these changes
Apr 22, 2024
kamfretoz
approved these changes
Apr 22, 2024
`Cs + Cd*Ad, Cs - Cd*Ad, Cd*(1 - Ad), Cs*(1 + Ad), Cs*(1 - Ad).`
lightningterror
force-pushed
the
gs_extend_blend_pass2
branch
from
1a41518 to
c59aefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/HW: Extend blend second pass to more blend formulas.
Cs + Cd*Ad, Cs - Cd*Ad, Cd*(1 - Ad), Cs*(1 + Ad), Cs*(1 - Ad).Rationale behind Changes
More accuracy on basic blend on dx.
Suggested Testing Steps
Test scarface, mgs3, tokyo extreme racer.
Eye Candy:
Scarface, master vs pr dx basic blend: