GS/TC: Read indexed texture from GS memory if complete dirty overlap #11031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Avoids reading indexed data from a target if the area completely overlaps (meaning there was an upload)
Rationale behind Changes
There were false positives and breaks in some games due to it reading this out of targets. Plus these changes saved a few uploads.
Suggested Testing Steps
Test a smattering of games including those listed below.
Fixes WW1 - Red Baron
Master:
PR:
Other changes shown in the GS dump run
catwoman_ghost
Draw Calls: +7 [381=>388]
Render Passes: +2 [124=>126]
Uploads: +3 [40=>43]
cod2
Draw Calls: -12 [93=>81]
Render Passes: -21 [54=>33]
Copies: -8 [9=>1]
Uploads: -7 [40=>33]
Crime_Life_-_Gang_Wars__PAL-M5__SLES-52122
Draw Calls: -3 [398=>395]
Render Passes: -4 [78=>74]
Copies: -2 [20=>18]
Uploads: -3 [29=>26]
Fight Night - Round 3_SLUS-21383_20220618124952
Draw Calls: -2 [839=>837]
Render Passes: -3 [27=>24]
Copies: -1 [6=>5]
Uploads: -1 [6=>5]
Project_-_Snowblind_SLUS-21037_20240316203245
Draw Calls: +22 [302=>324]
Render Passes: +12 [152=>164]
Copies: +1 [8=>9]
Uploads: +9 [100=>109]
Silent Hill 3_SLUS-20622_20220911173117
Draw Calls: -1 [829=>828]
Render Passes: -1 [18=>17]
Copies: -1 [6=>5]
Uploads: -1 [9=>8]
sniper_elite
Draw Calls: -7 [1321=>1314]
Render Passes: -9 [468=>459]
Copies: -3 [16=>13]
Uploads: -1 [27=>26]