Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/TC: Read indexed texture from GS memory if complete dirty overlap #11031

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

refractionpcsx2
Copy link
Member

Description of Changes

Avoids reading indexed data from a target if the area completely overlaps (meaning there was an upload)

Rationale behind Changes

There were false positives and breaks in some games due to it reading this out of targets. Plus these changes saved a few uploads.

Suggested Testing Steps

Test a smattering of games including those listed below.

Fixes WW1 - Red Baron

Master:
image
PR:
image

Other changes shown in the GS dump run

catwoman_ghost
Draw Calls: +7 [381=>388]
Render Passes: +2 [124=>126]
Uploads: +3 [40=>43]

cod2
Draw Calls: -12 [93=>81]
Render Passes: -21 [54=>33]
Copies: -8 [9=>1]
Uploads: -7 [40=>33]

Crime_Life_-_Gang_Wars__PAL-M5__SLES-52122
Draw Calls: -3 [398=>395]
Render Passes: -4 [78=>74]
Copies: -2 [20=>18]
Uploads: -3 [29=>26]

Fight Night - Round 3_SLUS-21383_20220618124952
Draw Calls: -2 [839=>837]
Render Passes: -3 [27=>24]
Copies: -1 [6=>5]
Uploads: -1 [6=>5]

Project_-_Snowblind_SLUS-21037_20240316203245
Draw Calls: +22 [302=>324]
Render Passes: +12 [152=>164]
Copies: +1 [8=>9]
Uploads: +9 [100=>109]

Silent Hill 3_SLUS-20622_20220911173117
Draw Calls: -1 [829=>828]
Render Passes: -1 [18=>17]
Copies: -1 [6=>5]
Uploads: -1 [9=>8]

sniper_elite
Draw Calls: -7 [1321=>1314]
Render Passes: -9 [468=>459]
Copies: -3 [16=>13]
Uploads: -1 [27=>26]

@refractionpcsx2 refractionpcsx2 merged commit c16ac20 into master Apr 3, 2024
22 checks passed
@refractionpcsx2 refractionpcsx2 deleted the gs_indexedoverlap branch April 3, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants