Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Rearrange color on shuffle if SW Blend or TFX #11027

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

refractionpcsx2
Copy link
Member

@refractionpcsx2 refractionpcsx2 commented Apr 2, 2024

Description of Changes

Enables colour rearranging on shuffle on SW blend or TFX (not decal)

Rationale behind Changes

The colour can be modulated by the vertex colour, which means that the incoming colour will be wrong, this was happening on Ratchet & Clank Up Your Arsenal.

Suggested Testing Steps

Test Ratchet & Clank UYA, and a smattering of other games.

Ratchet:
Master:
image

PR:
image

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably change fbmask condiiton for dx, rendererhw line 3481

enable_fbmask_emulation = (m_vt.m_primclass != GS_TRIANGLE_CLASS);
to
enable_fbmask_emulation = (m_vt.m_primclass != GS_TRIANGLE_CLASS) || m_texture_shuffle;

@refractionpcsx2
Copy link
Member Author

Should probably change fbmask condiiton for dx, rendererhw line 3481

enable_fbmask_emulation = (m_vt.m_primclass != GS_TRIANGLE_CLASS); to enable_fbmask_emulation = (m_vt.m_primclass != GS_TRIANGLE_CLASS) || m_texture_shuffle;

I don't think I've ever seen a shuffle be triangles.

@refractionpcsx2 refractionpcsx2 merged commit 30f4e77 into master Apr 8, 2024
22 checks passed
@lightningterror lightningterror deleted the gs_shuffle_arrange branch April 8, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants