GS/HW: Adjust blend mix for impossible blend. #10907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GS
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
GS: Metal
labels
|
Metal Gear Solid 3 Basic Blending DX11 Master
Metal Gear Solid 3 Basic Blending DX11 PR
Black spots are slightly less black |
refractionpcsx2
force-pushed
the
gs_impossible_blend_correction
branch
from
3d73740 to
d7059e0
Compare
lightningterror
force-pushed
the
gs_impossible_blend_correction
branch
4 times, most recently
from
cf3a915 to
a96c6e4
Compare
|
Some other images of big differences: Other games only show a very slight difference in brightness. |
Since we can't do Cd*(Alpha + 1) - Cs*Alpha in hw blend what we can do is adjust the Cs value that will be subtracted, this way we can get a better result in hw blend. Result is still wrong but less wrong than before.
lightningterror
force-pushed
the
gs_impossible_blend_correction
branch
from
a96c6e4 to
6bb32a8
Compare
JordanTheToaster
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Since we can't do
Cd*(Alpha + 1) - Cs*Alphain hw blend what we can do is adjust the Cs value that will be subtracted, this way we can get a better result in hw blend. Result is still wrong but less wrong than before.Rationale behind Changes
Accuracy.
Suggested Testing Steps
This is mostly for dx11/12. Vulkan, GL will only hit this path if barriers are disabled.
Makes dx hw blend suck less.
Test DX blending, list of games in the text file.
Result will still be wrong but less wrong.
List.txt