Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmmanager:revert gpu logging #10892

Merged
merged 1 commit into from
Mar 7, 2024
Merged

vmmanager:revert gpu logging #10892

merged 1 commit into from
Mar 7, 2024

Conversation

F0bes
Copy link
Member

@F0bes F0bes commented Mar 7, 2024

Description of Changes

Rationale behind Changes

Suggested Testing Steps

@refractionpcsx2 refractionpcsx2 merged commit 483c7f4 into master Mar 7, 2024
22 checks passed
@refractionpcsx2 refractionpcsx2 deleted the fhdsbgsdfh branch March 7, 2024 02:34
@stenzek
Copy link
Contributor

stenzek commented Mar 7, 2024

Just taking the additional issues on here, since it was missed in the original PR:

  1. You can't assume the presence of glxinfo, Ubuntu systems don't have it installed by default.
  2. glxinfo creates a GL context, which is going to power up discrete GPUs if it's e.g. overridden via an environment variable, resulting in several seconds delay on startup.
  3. /etc/os-release is going to be meaningless when running in a flatpak, because it's the container/runtime environment, and you can't access the host.
  4. Mac wasn't considered in GPU logging.

If it's part of a support request, then ehh, whatever, but otherwise the GS startup (which we already log) is a more accurate source of truth, since that's going to show the driver version, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants