ci: Switch Flatpak build to flathub-infra/flatpak-github-actions #10838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flathub team has recently forked flatpak-github-actions and merged various PRs submitted to the original repo. However, it's not versioned (yet?), so pin the latest commit instead. Additionally, enable validation of the build using flatpak-builder-lint, and run all steps in the container with the runtime and required tooling baked in.
|
We're in the process of merging similar change for OBS. I will un-draft this when it's merged and confirmed working over there. |
barthalion
force-pushed
the
patch-2
branch
2 times, most recently
from
c17250c to
1f2abaa
Compare
|
This should be good to go. OBS's counterpart has also been merged yesterday. cc @stenzek |
|
Seems to still run fine from a quick check. I'll manually trigger the release push and see how it goes, thanks! |
|
FYI, release seems to work fine from my brief testing, apart from having to shift the safe directory workaround further up. |
vertver
pushed a commit
to vertver/pcsx2-gdbserver
that referenced
this pull request
Apr 4, 2024
…X2#10838) * ci: Switch Flatpak build to flathub-infra/flatpak-github-actions Flathub team has recently forked flatpak-github-actions and merged various PRs submitted to the original repo. However, it's not versioned (yet?), so pin the latest commit instead. Additionally, enable validation of the build using flatpak-builder-lint, and run all steps in the container with the runtime and required tooling baked in. * Update mirror-screenshots-url * Shush git complaining about "dubious" ownership * Update date format to iso8601 * Fix flatpak-builder-lint invocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Flathub team has recently forked flatpak-github-actions and merged various PRs submitted to the original repo. However, it's not versioned (yet?), so pin the latest commit instead.
Additionally, enable validation of the build using flatpak-builder-lint, and run all steps in the container with the runtime and required tooling baked in.
Rationale behind Changes
The changes switch CI to the maintained actions fork/image, and uses the action as it's intended by its authors.
Suggested Testing Steps
Sadly, most likely requires the usual GitHub Actions loop of testing in production.