GS/OpenGL: Use EGL 1.5 platform interface #10827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenzek
force-pushed
the
egl
branch
2 times, most recently
from
823a94c to
d07f901
Compare
kamfretoz
approved these changes
Feb 18, 2024
|
I don't know if this helps, but I ran this PR on my laptop which is running Manjaro and has an Intel iGPU. The device description reads 'Alder Lake-P GT2 [Iris Xe Graphics]'. I just booted into the BIOS with OpenGL, so this was a pretty shallow test. |
github-actions
bot
added
Build | Project System
USB
Dependencies
kamfretoz
approved these changes
Apr 5, 2024
|
works on Quadro K2200 on linux |
|
Also ran on my GTX 1070 with latest drivers, and there was no issue getting in-game, switching to OpenGL, and playing around for a few minutes. |
|
On my Intel Xe laptop (tested latest commit), Ratchet's doing just fine walking in and out of his house on OpenGL, so all good on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Instead of crossing our fingers and hoping that the driver can work out the correct EGL platform/backend, we can use the platform extension to explicitly ask for a platform that matches the window we're creating it for.
EGL 1.5 has been a thing for over a decade, although Mesa at least doesn't implement it fully. But they do implement the platform extension, hopefully everyone else does too...
Rationale behind Changes
Stops a potential crash due to selecting the wrong EGL platform? Does this actually happen?
Apparently some users were getting a crash in
eglGetDisplay()...Suggested Testing Steps
Make sure Intel, AMD and NVIDIA OpenGL still works on Linux.