Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMManager: Log power profile and GPUs on startup #10824

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

F0bes
Copy link
Member

@F0bes F0bes commented Feb 17, 2024

Description of Changes

  • Implements power profile logging on Windows
  • Implements logging GPUs on Windows and Linux*
  • Implements distro logging on Linux (Instead of just 'Linux')

*There are some limitations on driver version logging on Linux. It should always work for the dGPU (which is really what matters most).

Rationale behind Changes

Improves the ability to provide support when you can see if the user has set a poor power profile, or if their drivers are outdated.

Suggested Testing Steps

Run PCSX2 and look at the console.

Linux example
linux_startup_console

Windows example (Sorry, two screenshots, and the driver version is now aligned like Linux)
windows_startup_console
windows_startup_console_gpu

@F0bes F0bes marked this pull request as draft February 18, 2024 00:17
@stenzek
Copy link
Contributor

stenzek commented Feb 18, 2024

For windows, you'd be better off enumerating the devices in the registry. IIRC enumerating adapters can bring dual GPU setups out of sleep, which would delay startup by several seconds. Same with invoking nvidia-smi or whatever on Linux.

An alternative approach that I've suggested in the past, would be to have a "generate support report" type button/menu, which dumps all this information, as well as configuration etc, to a file. Doesn't matter if that takes several seconds to run.

@F0bes
Copy link
Member Author

F0bes commented Feb 18, 2024

For windows, you'd be better off enumerating the devices in the registry. IIRC enumerating adapters can bring dual GPU setups out of sleep, which would delay startup by several seconds. Same with invoking nvidia-smi or whatever on Linux.

I was worried about the same thing. This all runs on the CPU thread though so it shouldn't be an issue if you're using PCSX2 via the UI (by the time you pick a game it should be ready). Maybe I can put this into its own temporary thread? There might be the issue of something else using the console while it's running though, I haven't checked.

An alternative approach that I've suggested in the past, would be to have a "generate support report" type button/menu, which dumps all this information, as well as configuration etc, to a file. Doesn't matter if that takes several seconds to run.

If this is the desired approach, I will remove the GPU portion of the this PR. I don't really want to get into UI work.

I also need to fix pulling the build string from /etc/os-release apparently it's up to the distro if they want to use quotes or not. Can't have anything fully standardized on Linux.

@F0bes F0bes marked this pull request as ready for review February 18, 2024 23:49
Copy link
Contributor

@kamfretoz kamfretoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

image

@stenzek
Copy link
Contributor

stenzek commented Feb 19, 2024

If this is the desired approach, I will remove the GPU portion of the this PR. I don't really want to get into UI work.

You could just comment it out/surround with #if 0, that way it can be used for the support log generation later on.

@refractionpcsx2 refractionpcsx2 merged commit 46e039d into PCSX2:master Mar 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants