-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMManager: Log power profile and GPUs on startup #10824
Conversation
92cd4b7
to
57f5059
Compare
For windows, you'd be better off enumerating the devices in the registry. IIRC enumerating adapters can bring dual GPU setups out of sleep, which would delay startup by several seconds. Same with invoking nvidia-smi or whatever on Linux. An alternative approach that I've suggested in the past, would be to have a "generate support report" type button/menu, which dumps all this information, as well as configuration etc, to a file. Doesn't matter if that takes several seconds to run. |
I was worried about the same thing. This all runs on the CPU thread though so it shouldn't be an issue if you're using PCSX2 via the UI (by the time you pick a game it should be ready). Maybe I can put this into its own temporary thread? There might be the issue of something else using the console while it's running though, I haven't checked.
If this is the desired approach, I will remove the GPU portion of the this PR. I don't really want to get into UI work. I also need to fix pulling the build string from |
57f5059
to
56a8b49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just comment it out/surround with |
56a8b49
to
efbab85
Compare
Description of Changes
*There are some limitations on driver version logging on Linux. It should always work for the dGPU (which is really what matters most).
Rationale behind Changes
Improves the ability to provide support when you can see if the user has set a poor power profile, or if their drivers are outdated.
Suggested Testing Steps
Run PCSX2 and look at the console.
Linux example
Windows example (Sorry, two screenshots, and the driver version is now aligned like Linux)