GS: Fix crop scaling for software and bilinear (sharp) #10816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamfretoz
approved these changes
Feb 15, 2024
|
Thanks for testing folks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes crop scaling when in software mode, but also if your internal resolution was lower than the window size and you used Bilinear (Sharp) filtering
Rationale behind Changes
Software mode: It was using HW upscale values, regardless of the current renderer, it now forces x1 for calculating software mode src size.
Bilinear (Sharp): When this option is active, the "current" framebuffer size gets increased to be larger than the window. Unfortunately the crop amount is done on this framebuffer, so it was resulting in bad amounts of cropping. It now adjusts the crop amount based on the real framebuffer size vs the "current" framebuffer size.
Suggested Testing Steps
Test crop values in software and hardware at different resolutions, including Bilinear (Sharp) mode, try different window sizes, make sure the cropping doesn't completely take a dump