Debugger: Migrates Memory Search tab to it's own widget #10813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the Memory Search fucntionality to it's own widget so as to not pollute the CpuWidget with search related functionality, especially as it is intended to grow in scope. CpuWidget is fairly general and as such everything tends to get tossed together which makes it harder to navigate/understand/maintain.
Mrlinkwii
approved these changes
Feb 15, 2024
kamfretoz
approved these changes
Feb 15, 2024
JordanTheToaster
approved these changes
Feb 17, 2024
F0bes
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Moves Memory Search UI into it's own custom widget and migrates the search related functions from
CpuWidget.h/cpp/uito their ownMemorySearchWidget.Rationale behind Changes
The scope of Memory search related functionality is increasing and the
CpuWidgetis already fairly bloated being a general parent of a lot of different and unrelated functionality. This helps makeCpuWidgeteasier to read/understand/maintain and allows the newMemorySearchWidgetto expand in functionality and improve focus.Suggested Testing Steps
This impacts all search related functionality, and integration between other components, such as double clicking an address and seeing it in Memory View, or visiting a search result in disassembly view, or taking a search result into saved addresses model.
Note:
Also makes the background color of the memory search widget a slightly darker color. The original color is set via witchcraft and sorcery and the new widget does not approve.