Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Adds on hover description to 'All CRCs' on hover for cheat/patch settings #10593

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

Daniel-McCarthy
Copy link
Contributor

@Daniel-McCarthy Daniel-McCarthy commented Jan 9, 2024

Description of Changes

Add an on hover description to explain the purpose of the 'All CRCs' button in the Cheat and Patch Settings window.

Also adds a minor text change to adjust 'Kbps' to 'kbps' by request in graphics settings.

Rationale behind Changes

Reduces potential confusion about the exact purpose/effect it has.

Suggested Testing Steps

  • Just validating that the text appears on hover.
  • Validating Settings->Graphics->Recording shows the lowercase "kbps" text for Audio Bitrate.
    No other impact area.

Cheat & Patch Settings windows:
PCSX2 - All CRCs Description

Audio Bitrate text change:
image

@github-actions github-actions bot added the GUI/Qt label Jan 9, 2024
@kamfretoz
Copy link
Contributor

For consistency i think it'll fit better if we put the text on the description box below instead of on a tooltip, just like how things are laid out on the main PCSX2 settings.

image-20.png

@refractionpcsx2
Copy link
Member

For consistency i think it'll fit better if we put the text on the description box below instead of on a tooltip, just like how things are laid out on the main PCSX2 settings.

I agree the hover should put it in the box at the bottom.

Daniel-McCarthy and others added 2 commits January 11, 2024 21:17
…tings

Add an on hover description to explain the purpose of the 'All CRCs' button in the Cheat and Patch Settings window.
@Daniel-McCarthy Daniel-McCarthy force-pushed the AllCRCsDescriptionOnHover branch from c02b27c to 501832f Compare January 12, 2024 03:18
@Daniel-McCarthy
Copy link
Contributor Author

For consistency i think it'll fit better if we put the text on the description box below instead of on a tooltip, just like how things are laid out on the main PCSX2 settings.

Good call, I've updated it to do this. 👍

@stenzek stenzek merged commit f416eb3 into PCSX2:master Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants