Misc: CMake tidy-up, replace non-constant shift immediates in GSVector #10501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Works around the requirement for the offsetof parameter to be constant.
Moves GSVector shift immediates over to a template parameter, since you can't use non-constant shift immediates for NEON, so this needs to happen anyway. And, less importantly, apparently GCC 13 doesn't like it.
Also removes the __m128 overloads - it's too easy to mistake for a variable shift (which doesn't exist in SSE4), instead it takes the shift amount from the lowest 32-bits.
Removes a bunch of redundant checks from the CMake scripts, and uses standardized platform names.
Adds a warning in caps for anyone trying to build with GCC (we only support Clang/MSVC).
Rationale behind Changes
Janitor part 3?
Closes #10500, although GCC 13 is still broken on Ubuntu 23.10.
Suggested Testing Steps
Make sure software renderer still works.
Note to self: do a dump run before merging.