GS/HW: Fix 16bit depth conversion in shuffles + fix NFSU CRC #10447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes the 16bit depth conversion on shuffles
Also fix the size of the shuffle draw in the CRC hack for NFS Undercover. Handling the shuffle properly is likely possible, but would need a lot of retooling of the split shuffle handling, and I suspect it will break things.
Rationale behind Changes
When the texture was actually 16bit depth on a shuffle, it was telling the shader that the format was actually 32bit, so the conversion was incorrect, breaking the shuffle. Used as a DOF effect.
The CRC was getting trolled by the shuffle code which was halving the width of the draw.
Suggested Testing Steps
Test NFS Undercover, nothing else really affected.
Master:
PR: