CI: migrate to upload-artifact@v4 and download-artifact@v4

[dependabot]

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

• @​vmjoseph made their first contribution in actions/upload-artifact#464

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

• chore(github): remove trailing whitespaces by @​ljmf00 in actions/upload-artifact#313
• Bump @​actions/artifact version to v1.1.2 by @​bethanyj28 in actions/upload-artifact#436

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

• Update all @actions/* NPM packages to their latest versions- #374
• Update all dev dependencies to their most recent versions - #375

v3.1.1

• Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

• Bump @​actions/artifact to v1.1.0 (actions/upload-artifact#327)
  • Adds checksum headers on artifact upload (actions/toolkit#1095) (actions/toolkit#1063)

Commits

• c7d193f Merge pull request #466 from actions/v4-beta
• 13131bb licensed cache
• 4a6c273 Merge branch 'main' into v4-beta
• f391bb9 Merge pull request #465 from actions/robherley/v4-documentation
• 9653d03 Apply suggestions from code review
• 875b630 add limitations section
• ecb2146 add compression example
• 5e7604f trim some repeated info
• d6437d0 naming
• 1b56155 s/v4-beta/v4/g
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[xTVaser]

Tested here https://github.com/xTVaser/pcsx2-rr/releases/tag/v1.4.11 seems to work fine, no idea where the flatpak gets uploaded to the release, because linux_build_flatpak.yml has no upload-artifact step. So maybe it's setup to only work on PCSX2/pcsx2 / handled by one of the flatpak actions?

This also exposed an issue in the PR artifacts -- v5 forbids duplicate artifact keys, and all windows variants were uploading and overwriting the same artifact name. Now cmake/msvc/clang/sse4/avx2 combinations should be separate artifacts. https://github.com/xTVaser/pcsx2-rr/actions/runs/7296017784/job/19883221584

Also updated the labeler workflow to the new v5 config file format, tested here xTVaser#128 so i wouldn't expect it to explode.

One nice feature about the v4 upload-artifacts if you didn't know is you can finally download them while a workflow is partially complete (ie. you can download artifacts from workflow A while B and C are still running)

[xTVaser]

I think this is good to go, did another test release after fixing artifact names and they match the current releases format:

I don't think there will be any issues when it comes to the flatpak cron job. I'm not 100% sure how the flatpak cli works but i couldn't find any explicit passing of "here's the flatpak i want to publish" so I assume it just uploads whatever it finds in the current directory.

This is why i moved the upload-artifact to after the flatpak/flatpak-github-actions/flat-manager execution and checked that their action code does no downloading of the artifact that it previously uploaded https://github.com/flatpak/flatpak-github-actions/blob/master/flat-manager/index.js