DiscordRPC: Show session time in Discord Rich Presence #10397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanTheToaster
approved these changes
Dec 12, 2023
Mrlinkwii
approved these changes
Dec 12, 2023
kamfretoz
approved these changes
Dec 13, 2023
CookiePLMonster
force-pushed
the
discord-rpc
branch
from
7c7c50f to
bf0d01f
Compare
CookiePLMonster
force-pushed
the
discord-rpc
branch
from
bf0d01f to
ae6aedd
Compare
JordanTheToaster
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR changes the way Discord Rich Presence shows time elapsed. Now instead of updating on every single RPC change, the time only gets reset on:
Rationale behind Changes
It is more meaningful to show how long the user has been in a specific game than to show how long the current Rich Presence string has been active for.
Suggested Testing Steps
Closes #10390