Build: Fix up various warnings, increase variable readability #10085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
build_warningmaint
branch
2 times, most recently
from
7c1a34a to
24a86c7
Compare
kamfretoz
approved these changes
Oct 10, 2023
Mrlinkwii
approved these changes
Oct 10, 2023
JordanTheToaster
approved these changes
Oct 10, 2023
refractionpcsx2
force-pushed
the
build_warningmaint
branch
from
24a86c7 to
bbbcbac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Improve naming of CDVD variables
Clean up C style casting where possible and remove some technical undefined behaviour.
Get rid of some dumb things
Rationale behind Changes
Cleanup is good
Suggested Testing Steps
Test some random games, make sure everything works as before, including loading BIOS region info when fast booting.