Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: A bunch of stuff #10083

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Conversation

F0bes
Copy link
Member

@F0bes F0bes commented Oct 10, 2023

Description of Changes

Implement sorting for the thread list
Implement export CSVs for breakpoints, thread lists, and call stacks
Implement importing CSVs for breakpoints
Fixes an issue with the context menu pop up location
Implements stubbing (noping) functions
Implements restoring instructions that have been noped or re-assembled
Implements restoring functions that have been stubbed
Implements the ability to view long function names in the disassembly view by clicking on function entry points
Demangle function names in the disassembly view

Rationale behind Changes

Most of these were by request or were just minor issues.
Importing breakpoints via CSVs was added so you can restore / share your breakpoint setups. For example:

TYPE,OFFSET,SIZE / LABEL,INSTRUCTION,CONDITION,HITS,ENABLED
8,33634c,,nop,v0 != 1,0,1
8,336354,,nop,a2 == 0xff,0,0
3,336350,1,,,0,2
7,336320,5,,,0,0
1,336300,ff,,,0,0
2,3362c0,1,,,0,0

Copy that and use the "Paste from CSV" context option to load my breakpoints

Suggested Testing Steps

Try exporting and import breakpoints
Try assembling then restoring instructions
Try noping then restoring instructions
Try stubbing then restoring functions
See if the right click context menu for breakpoints,threads, and stack frames pop up at a sensible position
Try sorting the thread list
Try exporting the stack list and thread list using the new context menu
Click on a function name that is elided, it should un-elide and you'll be able to read it 🚀
Toggle demangling in the disassembly view by clicking the check box in the function list context menu

@F0bes F0bes force-pushed the thanksgiving-im-thankful-for-the-debugger branch from bf6f6bc to d8142d0 Compare October 10, 2023 01:20
@F0bes F0bes force-pushed the thanksgiving-im-thankful-for-the-debugger branch from d8142d0 to f93b782 Compare October 10, 2023 01:26
@F0bes F0bes force-pushed the thanksgiving-im-thankful-for-the-debugger branch from 4c35c62 to 224ed33 Compare October 10, 2023 01:53
@F0bes
Copy link
Member Author

F0bes commented Oct 10, 2023

I think I'm done adding to this. It's ready for testing. I'll send you an invoice later 😏

@stenzek stenzek merged commit 8d13877 into master Oct 12, 2023
@stenzek stenzek deleted the thanksgiving-im-thankful-for-the-debugger branch October 12, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants