Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Run the tables keybind handler before the widgets #10074

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

F0bes
Copy link
Member

@F0bes F0bes commented Oct 6, 2023

This fixes the issue of 'G' executing the go-to box instead of putting it into the text view

Description of Changes

Runs the tables keypress handler before the widget

Rationale behind Changes

If you were to click on the text area and press 'G', you'd end up opening the goto address box instead of inserting a 'G' into that address
CTRL+G is still an override and will work whether you're clicked into the text or hex area.

Suggested Testing Steps

  • Open the debugger
    • Click into the text area
      • Press 'G'
        • A 'G' should be inserted
      • Press 'g'
        • A 'g' should be inserted
      • Press CTRL + 'G'
        • The go to address box should pop up
    • Click into the hex area
      • Press 'g', 'G' or CTRL + 'G'
        • The go to address box should pop up

@F0bes F0bes added the Debugger label Oct 6, 2023
@github-actions github-actions bot added the GUI/Qt label Oct 6, 2023
@F0bes F0bes changed the title Debugger: Check table keypress handle first instead of widget Debugger: Run the table keybind handler before the widgets Oct 6, 2023
@F0bes F0bes changed the title Debugger: Run the table keybind handler before the widgets Debugger: Run the tables keybind handler before the widgets Oct 6, 2023
This fixes the issue of 'G' executing the go-to box instead of putting it into the text view
@F0bes F0bes force-pushed the memoryview-keybinds branch from ca1717d to 44bf1d2 Compare October 6, 2023 15:53
@stenzek stenzek merged commit b994d0a into master Oct 7, 2023
22 checks passed
@stenzek stenzek deleted the memoryview-keybinds branch October 7, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants