Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Convert depth16->rgba16 shader to integer #10053

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

refractionpcsx2
Copy link
Member

@refractionpcsx2 refractionpcsx2 commented Oct 1, 2023

Description of Changes

Converts the non-metal shaders (metal already does this) for depth 16 -> rgb5a1 to use integer full range conversion

Most of the work done by Stenzek (I mostly just helped with the debugging and poked the code in lol)

Rationale behind Changes

The old way had off by 1 problems and was not really possible to get correct without coming across rounding issues.

Suggested Testing Steps

Test Shadow Tower Abyss make sure the shadows render correctly and the screen isn't too dark.

Fixes #3281

Master:
image
image

PR:
image
image

@refractionpcsx2 refractionpcsx2 merged commit 16588ab into master Oct 1, 2023
@refractionpcsx2 refractionpcsx2 deleted the gs_float16torgb5a1 branch October 1, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadow Tower Abyss - Flickering and dark picture
1 participant