EE Cache: Writeback dirty cache entries when exiting the interpreter.

PCSX2 · Dec 8, 2024 · f24a269 · f24a269
1 parent ac968f9
commit f24a269
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/pcsx2/Cache.cpp b/pcsx2/Cache.cpp
@@ -163,6 +163,17 @@ void resetCache()
 	std::memset(&cache, 0, sizeof(cache));
 }
 
+void writebackCache()
+{
+	for (int i = 0; i < 64; i++)
+	{
+		for (int j = 0; j < 2; j++)
+		{
+			cache.lineAt(i, j).writeBackIfNeeded();
+		}
+	}
+}
+
 static bool findInCache(const CacheSet& set, uptr ppf, int* way)
 {
 	auto check = [&](int checkWay) -> bool {

diff --git a/pcsx2/Cache.h b/pcsx2/Cache.h
@@ -8,6 +8,9 @@
 #include "common/SingleRegisterTypes.h"
 
 void resetCache();
+// Dumps all dirty cache entries to memory
+// This was implemented to safely allow to emulator to go from int+cache to the recompiler.
+void writebackCache();
 void writeCache8(u32 mem, u8 value, bool validPFN = true);
 void writeCache16(u32 mem, u16 value, bool validPFN = true);
 void writeCache32(u32 mem, u32 value, bool validPFN = true);

diff --git a/pcsx2/Interpreter.cpp b/pcsx2/Interpreter.cpp
@@ -5,6 +5,7 @@
 #include "R5900OpcodeTables.h"
 #include "VMManager.h"
 #include "Elfheader.h"
+#include "Cache.h"
 
 #include "DebugTools/Breakpoints.h"
 
@@ -555,6 +556,7 @@ static void intEventTest()
 	if (intExitExecution)
 	{
 		intExitExecution = false;
+		writebackCache();
 		fastjmp_jmp(&intJmpBuf, 1);
 	}
 }
@@ -566,7 +568,10 @@ static void intSafeExitExecution()
 	if (eeEventTestIsActive)
 		intExitExecution = true;
 	else
+	{
+		writebackCache();
 		fastjmp_jmp(&intJmpBuf, 1);
+	}
 }
 
 static void intCancelInstruction()