Debugger: little refactor of GDB part of debugger

pcsx2-qt/Debugger/CpuWidget.cpp

@@ -611,7 +611,7 @@ void CpuWidget::updateFunctionList(bool whenEmpty)
 		const QString filter = m_ui.txtFuncSearch->text().toLower();
 
 		m_ui.treeModules->clear();
-		for (const auto& module : m_cpu.GetSymbolMap().GetModules())
+		for (const auto& module : m_cpu.getSymbolMap().GetModules())
 		{
 			QTreeWidgetItem* moduleItem = new QTreeWidgetItem(m_ui.treeModules, QStringList({QString(module.name.c_str()), QString("%0.%1").arg(module.version.major).arg(module.version.minor), QString::number(module.exports.size())}));
 			QList<QTreeWidgetItem*> functions;
@@ -762,14 +762,13 @@ void CpuWidget::onFuncListContextMenu(QPoint pos)
 		QAction* moduleViewAction = new QAction(tr("Module Tree"), m_ui.listFunctions);
 		moduleViewAction->setCheckable(true);
 		moduleViewAction->setChecked(m_moduleView);
-
 		connect(moduleViewAction, &QAction::triggered, [this] {
 			m_moduleView = !m_moduleView;
 			m_ui.treeModules->setVisible(m_moduleView);
 			m_ui.listFunctions->setVisible(!m_moduleView);
 			updateFunctionList();
 		});
-
+		
 		m_funclistContextMenu->addAction(moduleViewAction);
 	}
 	m_funclistContextMenu->popup(m_ui.listFunctions->viewport()->mapToGlobal(pos));

pcsx2/CMakeLists.txt

@@ -770,8 +770,6 @@ set(pcsx2DebugToolsSources
 	DebugTools/DisassemblyManager.cpp
 	DebugTools/ExpressionParser.cpp
 	DebugTools/GDBServer.cpp
-	DebugTools/GDBServerR3000.cpp
-	DebugTools/GDBServerR5900.cpp
 	DebugTools/MIPSAnalyst.cpp
 	DebugTools/MipsAssembler.cpp
 	DebugTools/MipsAssemblerTables.cpp
@@ -791,8 +789,6 @@ set(pcsx2DebugToolsHeaders
 	DebugTools/DisassemblyManager.h
 	DebugTools/ExpressionParser.h
 	DebugTools/GDBServer.h
-	DebugTools/GDBServerR3000.h
-	DebugTools/GDBServerR5900.h
 	DebugTools/MIPSAnalyst.h
 	DebugTools/MipsAssembler.h
 	DebugTools/MipsAssemblerTables.h

pcsx2/DebugTools/DebugServer.cpp

@@ -437,8 +437,8 @@ bool DebugNetworkServer::receiveAndSendPacket()
 	}
 
 	m_recv_buffer[receive_length] = 0;
-	Console.WriteLn(Color_Orange, "recv");
-	Console.WriteLn(Color_Gray, "%s", (char*)&m_recv_buffer[0]);
+	//Console.WriteLn(Color_Orange, "recv");
+	//Console.WriteLn(Color_Gray, "%s", (char*)&m_recv_buffer[0]);
 
 	const std::size_t localOffset = m_debugServerInterface->processPacket((char*)&m_recv_buffer.at(offset), receive_length, m_send_buffer.data(), outSize);
 	if (localOffset == std::size_t(-1))

pcsx2/DebugTools/GDBServer.cpp

@@ -1307,7 +1307,7 @@ std::size_t GDBServer::processPacket(const char* inData, std::size_t inSize, voi
 			break;
 	}
 
-	if (endOffset + 2 > inSize)
+	auto processCPUThreadsPacket = [this, outData, &outSize]()
 	{
 		// Final offset + 2 can't be bigger than size so this packet might 
 		// be invalid or doesn't contain any of checksum.