Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ariant Coliseum: Fix score counting and trade conversation #227

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

HarkuLi
Copy link

@HarkuLi HarkuLi commented Mar 2, 2024

Score Counting

Description

The score counting of Ariant Coliseum is broken. Score of a player isn't updated after catching a monster.

Cause/Solution

Ariant score should be updated whenever a player catching a monster.

Trade Conversation

Description

Players can't exchange the "Palm Tree Beach Chair" after earning 100 points.

Cause/Solution

The order for checking conditions of Ariant point is wrong.
The correct order for checking conditions should be:

  1. Ariant points >= 100 => continue to exchange
  2. Ariant points + reward in this game >= 100 => hint that the player should convert the reward to points first
  3. Otherwise, the player doesn't have enough points to exchange the chair.

P0nk
P0nk previously approved these changes Jun 14, 2024
@P0nk
Copy link
Owner

P0nk commented Jun 14, 2024

Looks like I'm unable to merge due to merge conflicts. Could you please resolve them? I'm unable to see which file it is, but probably .gitignore.

@HarkuLi
Copy link
Author

HarkuLi commented Jun 19, 2024

I have rebased master branch and resolved the conflict in the .gitignore file.

@HarkuLi HarkuLi requested a review from P0nk June 19, 2024 11:04
@P0nk P0nk merged commit aab9823 into P0nk:master Jun 19, 2024
1 check passed
@HarkuLi HarkuLi deleted the feat/fix-ariant-coliseum branch June 20, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants