Add ability to fall back to scripts named after MapId.PortalName #207
+34
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeker1437
commented
Dec 21, 2023
Seeker1437
commented
- this allows running portal script even if the script node is unset in the WZ
- this allows running portal script even if the script node is unset
P0nk
requested changes
Feb 4, 2024
There was a problem hiding this comment.
I can see the usefulness in this feature, I'm just worried of decreased performance. This change means we will read from the file system for every single portal that is loaded (to check if a script exists).
I'll accept it, but I won't think twice about removing if it turns out to be a measurable performance hit.
Some minor improvements to be fixed before I approve.
|
When will this be merged? |
Shortly. I haven't been too active lately but am now getting back into things. |
|
Sorry for trying to help. |
|
Wow. Okay. |
|
Sorry, just was waste of everyone's time. Also maybe he will fix the network implementation. He's doing it completely wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.