Styling improvements for [sectionId] pages #233
Conversation
dankimberley
commented
Jun 27, 2024
•
dankimberley
commented
- Fixed text overflowing prev/next buttons - forward/back navigation buttons: text overflows the button #177
- Style improvements for learning outcomes as per Learning outcomes could use some good styling #229
- tailwind colours
| @@ -59,7 +63,7 @@ export const LinkedSection = (sectionLink: SectionLink) => { | |||
| <Tooltip title={tooltipTitle}> | |||
| <a href={`${sectionLink.url}`} className={`pointer-events-auto text-gray-600 hover:text-gray-500 opacity-50`}> | |||
| <div | |||
| className={`group rounded-md border-2 hover:border-4 ${borderColor} h-[55px] w-[150px] text-sm`} | |||
| className={`group rounded-md border-2 hover:border-4 ${borderColor} ${calcAnchorHeight} w-[150px] text-sm`} | |||
There was a problem hiding this comment.
Annoyingly this breaks whatever I had to do to get them to not move when the hover border width changed:
versus new:
I have absolutely no idea why? There might be an easy fix but it could certainly be fixed using box shadow rather than border? well I am never certain about anything when it comes to frontend.
BUT, we will spin this into another issue cause I would rather have them move slightly than the current text-overflow that we have.
|
Hey, great work 👍 , I have two minor changes regarding the coloring of elements and one thing that we will leave for another issue (the movement due to border size changes. Other than that, should be good to go. |
Co-authored-by: Alasdair Wilson <[email protected]>
Co-authored-by: Alasdair Wilson <[email protected]>
Thanks for this! I've committed those changes. Yeah border behaviour definitely not ideal - I'll have a look at the border movement. |
Great, I have made an issue for that here #234 |
