update: logic for same currency

OxCom · Jun 16, 2018 · 5ef52dc · 5ef52dc
1 parent a1bd9f3
commit 5ef52dc
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/Model/Currency/Import/Ecb.php b/Model/Currency/Import/Ecb.php
@@ -29,6 +29,11 @@ protected function _convert($currencyFrom, $currencyTo)
         // @codingStandardsIgnoreStop
         $this->doRequestDelay();
 
+        // there should not be any calls
+        if ($currencyFrom === $currencyTo) {
+            return 1;
+        }
+
         $rate = null;
         $url  = static::SOURCE_LINK;
 

diff --git a/Model/Currency/Import/Fixer.php b/Model/Currency/Import/Fixer.php
@@ -30,6 +30,11 @@ protected function _convert($currencyFrom, $currencyTo)
         // @codingStandardsIgnoreStop
         $this->doRequestDelay();
 
+        // there should not be any calls
+        if ($currencyFrom === $currencyTo) {
+            return 1;
+        }
+
         $rate = null;
         $url  = strtr(static::SOURCE_LINK, [
             '{{TOKEN}}' => $this->getAccessToken(),

diff --git a/Model/Currency/Import/Google.php b/Model/Currency/Import/Google.php
@@ -29,6 +29,11 @@ protected function _convert($currencyFrom, $currencyTo)
         // @codingStandardsIgnoreStop
         $this->doRequestDelay();
 
+        // there should not be any calls
+        if ($currencyFrom === $currencyTo) {
+            return 1;
+        }
+
         $zero = rand(1, 5);
         $value = pow(10, $zero);