Refactoring parameter class #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamAdamDay
requested changes
Mar 10, 2023
| @@ -21,131 +24,170 @@ class Parameters(dict): | |||
|
|
|||
| Parameters | |||
There was a problem hiding this comment.
Makes sense to name this "Attributes" now rather than "Parameters"
There was a problem hiding this comment.
I would have thought it's the "parameters of the experiment" (in which case "attributes" makes less sense)
There was a problem hiding this comment.
It's about the docstring standard which we're following. These are more properly attributes of the class, rather than parameters. It's not a big deal though
| assert self.num_iterations == 1 | ||
|
|
||
| def update_from_dict(self, dictionary: dict, *, skip_keys: list = ()): | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Dataclasses are mutable, so you can just implement this...
SamAdamDay
reviewed
Mar 10, 2023
SamAdamDay
requested changes
Mar 13, 2023
| # refresh_every ∈ {-1} ∪ {1,2,3,...} | ||
| assert isinstance(self.refresh_every, int) | ||
| assert self.refresh_every == -1 or self.refresh_every >= 1 | ||
|
|
| @@ -21,131 +24,170 @@ class Parameters(dict): | |||
|
|
|||
| Parameters | |||
There was a problem hiding this comment.
It's about the docstring standard which we're following. These are more properly attributes of the class, rather than parameters. It's not a big deal though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.