Skip to content

Commit

Permalink
Merge branch 'main' into cdc_visitor
Browse files Browse the repository at this point in the history
  • Loading branch information
OussamaSaoudi-db authored Nov 20, 2024
2 parents 058fc60 + ccf5e9a commit 6e85cd7
Show file tree
Hide file tree
Showing 10 changed files with 90 additions and 90 deletions.
158 changes: 79 additions & 79 deletions CHANGELOG.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ edition = "2021"
homepage = "https://delta.io"
keywords = ["deltalake", "delta", "datalake"]
license = "Apache-2.0"
repository = "https://github.com/delta-incubator/delta-kernel-rs"
repository = "https://github.com/delta-io/delta-kernel-rs"
readme = "README.md"
version = "0.4.0"

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ Some design principles which should be considered:
[delta-github]: https://github.com/delta-io/delta
[java-kernel]: https://github.com/delta-io/delta/tree/master/kernel
[rustup]: https://rustup.rs
[architecture.md]: https://github.com/delta-incubator/delta-kernel-rs/tree/master/architecture.md
[architecture.md]: https://github.com/delta-io/delta-kernel-rs/tree/master/architecture.md
[dat]: https://github.com/delta-incubator/dat
[derive-macros]: https://doc.rust-lang.org/reference/procedural-macros.html
[API Docs]: https://docs.rs/delta_kernel/latest/delta_kernel/
Expand Down
2 changes: 1 addition & 1 deletion ffi/src/expressions/kernel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ type VisitUnaryFn = extern "C" fn(data: *mut c_void, sibling_list_id: usize, chi
/// to visitor methods
/// TODO: Visit type information in struct field and null. This will likely involve using the schema
/// visitor. Note that struct literals are currently in flux, and may change significantly. Here is the relevant
/// issue: https://github.com/delta-incubator/delta-kernel-rs/issues/412
/// issue: https://github.com/delta-io/delta-kernel-rs/issues/412
#[repr(C)]
pub struct EngineExpressionVisitor {
/// An opaque engine state pointer
Expand Down
2 changes: 1 addition & 1 deletion kernel/src/engine/parquet_row_group_skipping.rs
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ impl<'a> ParquetStatsProvider for RowGroupFilter<'a> {
// actually exists in the table's logical schema, and that any necessary logical to
// physical name mapping has been performed. Because we currently lack both the
// validation and the name mapping support, we must disable this optimization for the
// time being. See https://github.com/delta-incubator/delta-kernel-rs/issues/434.
// time being. See https://github.com/delta-io/delta-kernel-rs/issues/434.
return Some(self.get_parquet_rowcount_stat()).filter(|_| false);
};

Expand Down
2 changes: 1 addition & 1 deletion kernel/src/expressions/scalars.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ impl ArrayData {
}

#[deprecated(
note = "These fields will be removed eventually and are unstable. See https://github.com/delta-incubator/delta-kernel-rs/issues/291"
note = "These fields will be removed eventually and are unstable. See https://github.com/delta-io/delta-kernel-rs/issues/291"
)]
pub fn array_elements(&self) -> &[Scalar] {
&self.elements
Expand Down
4 changes: 2 additions & 2 deletions kernel/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
//! [read-table-single-threaded] example (and for a more complex multi-threaded reader see the
//! [read-table-multi-threaded] example).
//!
//! [read-table-single-threaded]: https://github.com/delta-incubator/delta-kernel-rs/tree/main/kernel/examples/read-table-single-threaded
//! [read-table-multi-threaded]: https://github.com/delta-incubator/delta-kernel-rs/tree/main/kernel/examples/read-table-multi-threaded
//! [read-table-single-threaded]: https://github.com/delta-io/delta-kernel-rs/tree/main/kernel/examples/read-table-single-threaded
//! [read-table-multi-threaded]: https://github.com/delta-io/delta-kernel-rs/tree/main/kernel/examples/read-table-multi-threaded
//!
//! # Engine traits
//!
Expand Down
4 changes: 2 additions & 2 deletions kernel/src/log_segment/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ fn test_replay_for_metadata() {
//
// NOTE: Each checkpoint part is a single-row file -- guaranteed to produce one row group.
//
// WARNING: https://github.com/delta-incubator/delta-kernel-rs/issues/434 -- We currently
// WARNING: https://github.com/delta-io/delta-kernel-rs/issues/434 -- We currently
// read parts 1 and 5 (4 in all instead of 2) because row group skipping is disabled for
// missing columns, but can still skip part 3 because has valid nullcount stats for P&M.
assert_eq!(data.len(), 4);
Expand Down Expand Up @@ -260,7 +260,7 @@ fn build_snapshot_with_bad_checkpoint_hint_fails() {
#[ignore]
#[test]
fn build_snapshot_with_missing_checkpoint_part_no_hint() {
// TODO: Handle checkpoints correctly so that this test passes: https://github.com/delta-incubator/delta-kernel-rs/issues/497
// TODO: Handle checkpoints correctly so that this test passes: https://github.com/delta-io/delta-kernel-rs/issues/497

// Part 2 of 3 is missing from checkpoint 5. The Snapshot should be made of checkpoint
// number 3 and commit files 4 to 7.
Expand Down
2 changes: 1 addition & 1 deletion kernel/src/scan/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ mod tests {
// Predicate over a logically valid but physically missing column. No data files should be
// returned because the column is inferred to be all-null.
//
// WARNING: https://github.com/delta-incubator/delta-kernel-rs/issues/434 - This
// WARNING: https://github.com/delta-io/delta-kernel-rs/issues/434 - This
// optimization is currently disabled, so the one data file is still returned.
let predicate = Arc::new(column_expr!("missing").lt(1000i64));
let scan = snapshot
Expand Down
2 changes: 1 addition & 1 deletion kernel/tests/read.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1033,7 +1033,7 @@ fn predicate_references_invalid_missing_column() -> Result<(), Box<dyn std::erro
// Attempted skipping over a logically valid but physically missing column. We should be able to
// skip the data file because the missing column is inferred to be all-null.
//
// WARNING: https://github.com/delta-incubator/delta-kernel-rs/issues/434 -- currently disabled.
// WARNING: https://github.com/delta-io/delta-kernel-rs/issues/434 -- currently disabled.
//
//let expected = vec![
// "+--------+",
Expand Down

0 comments on commit 6e85cd7

Please sign in to comment.