Fix nimbus fetching mechanism for ReadTheDocs
#2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
fetch()method ofnimbus()to add aUserAgent, thus preventing requests from ReadTheDocs from being forbidden by GitHub.registry.txtfiles and testing data from non-Ouranosinc/xclim-testdatarepositories that follow the same conventions (forks,xhydro-testdata, etc.).Does this PR introduce a breaking change?
Not really. The
fetchcalls have been modified and the registry files for non-Ouranosinc/xclim-testdatafiles are now saved to the testing folder with the following convention:registry.{repo-name}.{branch-name}.txt.Other information:
readthedocs/readthedocs.org#11763