Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nimbus URL joining #1997

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Fix nimbus URL joining #1997

merged 4 commits into from
Nov 15, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 15, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fixed an issue that was causing URLs to include a // between the repository and branch fields.

Does this PR introduce a breaking change?

No.

Other information:

While this was working fine for returning files already available on disk, when nimbus was fetching files remotely when launched from a Jupyter notebook, this was failing.

Related: Ouranosinc/xscen#492

@Zeitsperre Zeitsperre added the bug Something isn't working label Nov 15, 2024
@Zeitsperre Zeitsperre self-assigned this Nov 15, 2024
aulemahal
aulemahal approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added the approved Approved for additional tests label Nov 15, 2024
@Zeitsperre Zeitsperre merged commit fe4066e into main Nov 15, 2024
21 checks passed
@Zeitsperre Zeitsperre deleted the fix-nimbus branch November 15, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

@RondeauG RondeauG Awaiting requested review from RondeauG

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @aulemahal