Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt SPEC0 calendar, drop Python3.9 #1915

Merged
merged 25 commits into from
Sep 18, 2024
Merged

Adopt SPEC0 calendar, drop Python3.9 #1915

merged 25 commits into from
Sep 18, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Sep 10, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Extends support for Python3.13 and drops support for Python3.9
  • Raises the base required versions for a handful of dependencies based on Scientific Python's SPEC 0 standard:
    • ipython to v8.5.0+
    • matplotlib to v3.6.0+
    • numpy to v1.23+
    • scikit-learn to v1.1.0+
  • Updates the codebase to use Python3.10+ conventions
  • nbsphinx has been pinned to v0.9.5+

Does this PR introduce a breaking change?

Yes. Python3.9 support has been dropped.

Other information:

https://scientific-python.org/specs/spec-0000/
https://peps.python.org/pep-0619/

Notable changes:

@Zeitsperre Zeitsperre added standards / conventions Suggestions on ways forward dependencies Pull requests that update a dependency file labels Sep 10, 2024
@Zeitsperre Zeitsperre added this to the v0.53.0 milestone Sep 10, 2024
@Zeitsperre Zeitsperre requested a review from a team September 10, 2024 16:57
@Zeitsperre Zeitsperre self-assigned this Sep 10, 2024
@github-actions github-actions bot added information For development/intsructional purposes docs Improvements to documenation labels Sep 10, 2024
Copy link

Note

It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2024.8.23).

No further action is required.

@github-actions github-actions bot added the CI Automation and Contiunous Integration label Sep 10, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Sep 13, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added sdba Issues concerning the sdba submodule. indicators Climate indices and indicators labels Sep 17, 2024
@Zeitsperre
Copy link
Collaborator Author

Python3.13 builds require changes in coveralls: TheKevJames/coveralls-python#523

@Zeitsperre
Copy link
Collaborator Author

Will be performing a squash+merge to erase my mistakes not pollute the git history.

@coveralls
Copy link

Coverage Status

coverage: 89.374% (-0.02%) from 89.394%
when pulling 24ac1ec on spec0-calendar
into e9ae422 on main.

@Zeitsperre Zeitsperre merged commit ba5901d into main Sep 18, 2024
22 of 23 checks passed
@Zeitsperre Zeitsperre deleted the spec0-calendar branch September 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration dependencies Pull requests that update a dependency file docs Improvements to documenation indicators Climate indices and indicators information For development/intsructional purposes sdba Issues concerning the sdba submodule. standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt the Scientific Python SPEC0 Python calendar
3 participants