Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle all nan case for loess smoothing #1699

Merged
merged 4 commits into from
Apr 5, 2024
Merged

handle all nan case for loess smoothing #1699

merged 4 commits into from
Apr 5, 2024

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Apr 4, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

before the all nan case would fail.

Other information:

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Apr 4, 2024
@juliettelavoie juliettelavoie requested a review from aulemahal April 4, 2024 18:18
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added the approved Approved for additional tests label Apr 4, 2024
@juliettelavoie
Copy link
Contributor Author

Can I ignore the License compliance issues and merge (it doesn't look blocked) ? Maintainer access is needed to see the details of the 2 fossa issues..

@aulemahal
Copy link
Collaborator

aulemahal commented Apr 5, 2024

Yes you can! I also don't have access to the report, but the issues reported by @tlogan2000 are more confusing than critical...

@coveralls
Copy link

Coverage Status

coverage: 90.19%. remained the same
when pulling db819b3 on fix-loess-nan
into c6c10cb on main.

@juliettelavoie juliettelavoie merged commit 534b7c8 into main Apr 5, 2024
18 of 19 checks passed
@juliettelavoie juliettelavoie deleted the fix-loess-nan branch April 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants