Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harden runner does not work on container images #1655

Merged
merged 2 commits into from
Feb 19, 2024
Merged

harden runner does not work on container images #1655

merged 2 commits into from
Feb 19, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Feb 19, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Removes the Harden Runner step in finish as it does not work with container images

Does this PR introduce a breaking change?

No.

Other information:

step-security/harden-runner#124

@Zeitsperre Zeitsperre requested a review from aulemahal February 19, 2024 18:24
@Zeitsperre Zeitsperre self-assigned this Feb 19, 2024
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Feb 19, 2024
@github-actions GitHub Actions
Copy link

Note
It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.12.14).

No further action is required.

@github-actions github-actions bot added the approved Approved for additional tests label Feb 19, 2024
@Zeitsperre Zeitsperre removed the request for review from aulemahal February 19, 2024 19:10
@Zeitsperre Zeitsperre merged commit 545ac67 into master Feb 19, 2024
28 checks passed
@Zeitsperre Zeitsperre deleted the remove-runner-on-container branch February 19, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests CI Automation and Contiunous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @RondeauG