Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint config update #1650

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Lint config update #1650

merged 2 commits into from
Feb 16, 2024

Conversation

Zeitsperre
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Updates the pyproject.toml configurations for ruff to the v0.2 conventions
  • Adds the codespell hook to the pre-commit configuration

Does this PR introduce a breaking change?

Nope.

Other information:

I forgot to add the codespell hook in my other PR. This doesn't require an entry in CHANGES.rst.

@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Feb 15, 2024
@Zeitsperre Zeitsperre added this to the v0.48.0 milestone Feb 15, 2024
@Zeitsperre Zeitsperre requested a review from aulemahal February 15, 2024 21:32
@Zeitsperre Zeitsperre self-assigned this Feb 15, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added CI Automation and Contiunous Integration docs Improvements to documenation labels Feb 15, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Feb 16, 2024
@Zeitsperre Zeitsperre mentioned this pull request Feb 16, 2024
Merged
5 tasks
@Zeitsperre Zeitsperre merged commit 5db4a75 into master Feb 16, 2024
19 checks passed
@Zeitsperre Zeitsperre deleted the lint-update branch February 16, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation standards / conventions Suggestions on ways forward
Projects
None yet
Milestone
v0.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @aulemahal