-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize code formatters with pre-commit
#1626
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
github-actions
bot
added
sdba
Issues concerning the sdba submodule.
API
Interfacing and User Concerns
docs
Improvements to documenation
indicators
Climate indices and indicators
labels
Jan 26, 2024
aulemahal
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
Interfacing and User Concerns
approved
Approved for additional tests
CI
Automation and Contiunous Integration
dependencies
Pull requests that update a dependency file
docs
Improvements to documenation
indicators
Climate indices and indicators
sdba
Issues concerning the sdba submodule.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
black
is now using year-2024 style conventions.dev
recipe-listed code formatters (black
,blackdoc
,isort
) to match theirpre-commit
equivalents.tox.ini
.isort
(currently used in Makefile) has been added to thedev
recipe andenvironment.yml
environment.yml
to use thePyPI
-providedbump-my-version
package.Does this PR introduce a breaking change?
Yes.
black
24.1.0 introduces several aesthetic changes to the code.isort
is now listed as a dependency. Bothblack
andisort
(andblackdoc
) are now pinned to preventpre-commit
andtox
formatting disagreements.Other information:
https://github.com/psf/black/releases/tag/24.1.0
callowayproject/bump-my-version#129