Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated mf_file call signatures #1506

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Remove deprecated mf_file call signatures #1506

merged 10 commits into from
Oct 18, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Oct 18, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • The mf_file call signature (deprecated in xclim v0.43.0) found in xclim.ensembles.create_ensemble (and xclim.ensembles._ens_align_dataset) has been removed.

Does this PR introduce a breaking change?

This call signature has been deprecated for some time, so no.

Other information:

@Zeitsperre Zeitsperre added the API Interfacing and User Concerns label Oct 18, 2023
@Zeitsperre Zeitsperre added this to the v0.46.0 milestone Oct 18, 2023
@Zeitsperre Zeitsperre requested a review from coxipi October 18, 2023 15:33
@Zeitsperre Zeitsperre self-assigned this Oct 18, 2023
@github-actions github-actions bot removed the API Interfacing and User Concerns label Oct 18, 2023
@Zeitsperre Zeitsperre changed the title Remove deprecatedn mf_file call signatures Remove deprecated mf_file call signatures Oct 18, 2023
@Zeitsperre Zeitsperre requested a review from aulemahal October 18, 2023 18:26
coxipi
coxipi approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@github-actions github-actions bot added the approved Approved for additional tests label Oct 18, 2023
@github-actions github-actions bot added information For development/intsructional purposes docs Improvements to documenation labels Oct 18, 2023
@Zeitsperre Zeitsperre merged commit 3d042f9 into master Oct 18, 2023
12 checks passed
@Zeitsperre Zeitsperre deleted the remove_deprecated branch October 18, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coxipi coxipi coxipi approved these changes

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests docs Improvements to documenation information For development/intsructional purposes
Projects
None yet
Milestone
v0.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @aulemahal @coxipi