Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase paragraph on indicators vs indices and add links to their respective documentation #1472

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

huard
Copy link
Collaborator

@huard huard commented Sep 8, 2023

Pull Request Checklist:

What kind of change does this PR introduce?

  • Small documentation change related to indices vs indicators.

Does this PR introduce a breaking change?

No

Other information:

The original issue says the distinction between indicators and indices should be front and center, but it's already in the first paragraph of the Usage section, so not sure where it could go to get more visibility. Suggestions welcome.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the docs Improvements to documenation label Sep 8, 2023
@huard huard requested a review from SarahG-579462 September 11, 2023 19:44
Copy link
Contributor

@SarahG-579462 SarahG-579462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added the approved Approved for additional tests label Sep 12, 2023
@huard huard merged commit 44079ac into master Sep 12, 2023
10 checks passed
@huard huard deleted the fix-1436 branch September 12, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
2 participants