-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wind power potential and wind profile indicators #1471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @huard, I think overall this looks great! There is one important change due to another typo in the Tobin (2018) paper, and some suggestions for the function descriptors.
xclim/indices/_conversion.py
Outdated
For non-standard air density (:math:`\rho`), the wind speed is scaled using | ||
:math:`v_n = v \left( \frac{\rho}{\rho_0} \right)^{1/3}`. | ||
|
||
Note that the temporal resolution of the wind speed time series has a significant influence on the results, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this is not necessary, but you could also note that temporal resolution may affect aggregation in time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to
Note that the temporal resolution of the wind speed time series has a significant influence on the results,
even when aggregated at longer time scales. Total annual power production will differ substantially if estimated
from hourly or daily wind speeds, due to the non-linearity of the production factor.
Is this what you meant ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
May be you could add real tests in test_atmos
?
Hi David, sorry for the long delay. I think the original wording was better. I was referring to, when summing up to create an annual power production estimate, they need to multiple by 3 if they use 3-hourly data, etc. But I'm not sure if that note is worth including.
From: David Huard ***@***.***>
Sent: Monday, September 18, 2023 9:02 AM
To: Ouranosinc/xclim ***@***.***>
Cc: laura-vanvliet ***@***.***>; Comment ***@***.***>
Subject: Re: [Ouranosinc/xclim] Add wind power potential and wind profile indicators (PR #1471)
@huard commented on this pull request.
________________________________
In xclim/indices/_conversion.py<#1471 (comment)>:
+ and rated speed, is constant between the rated and cut-out speed, and is zero for wind speeds above the cut-out
+ speed to avoid damage to the turbine :cite:p:`tobin_2018`:
+
+ .. math::
+
+ \begin{cases}
+ 0, & v < u_i \\
+ (v - u_i)^3 / (u_r - u_i)^3, & u_i ≤ v < u_r \\
+ 1, & u_r ≤ v < u_o \\
+ 0, & v ≥ u_o
+ \end{cases}
+
+ For non-standard air density (:math:`\rho`), the wind speed is scaled using
+ :math:`v_n = v \left( \frac{\rho}{\rho_0} \right)^{1/3}`.
+
+ Note that the temporal resolution of the wind speed time series has a significant influence on the results,
Changed to
Note that the temporal resolution of the wind speed time series has a significant influence on the results,
even when aggregated at longer time scales. Total annual power production will differ substantially if estimated
from hourly or daily wind speeds, due to the non-linearity of the production factor.
Is this what you meant ?
-
Reply to this email directly, view it on GitHub<#1471 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASLWXWBA5XVYBFH7ANHCAB3X3BV6PANCNFSM6AAAAAA4Q3FM7U>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
|
Ok, changed the wording of the docstring to simplify, and added a note explaining how to aggregate instantaneous power potential at lower frequencies. Tests have also been improved in the process, including one demoing the conversion to daily power production in MWh from 3-hourly values. Also fixed a bug in to_agg_units, but I note there are no explicit tests for this function. |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
Other information:
Ideally we`d add an indicator to compute air density, which is an optional input to the wind power potential.