Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better search results #1559

Closed
2 tasks done
aulemahal opened this issue Dec 12, 2023 · 1 comment · Fixed by #1593
Closed
2 tasks done

Better search results #1559

aulemahal opened this issue Dec 12, 2023 · 1 comment · Fixed by #1593
Labels
enhancement New feature or request
Milestone
v0.48.0

Comments

@aulemahal
Copy link
Collaborator

Addressing a Problem?

Current search results of the indicators page are purely alphabetical and include the "virtual" modules.

Potential Solution

  • Add a larger "weight" to the atmos indicators
  • Add a checkbox to include/exclude the virtual modules

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aulemahal aulemahal added the enhancement New feature or request label Dec 12, 2023
@aulemahal aulemahal added this to the v0.48.0 milestone Dec 12, 2023
@huard
Copy link
Collaborator

huard commented Dec 12, 2023 •
edited
Loading

Possiblement que boostDocument pourrais permettre d'ajouter du poids aux indicateurs qui proviennent d'atmos.

@aulemahal aulemahal mentioned this issue Jan 12, 2024
Merged
5 tasks
aulemahal added a commit that referenced this issue Jan 15, 2024
@aulemahal
Better indicators search (#1593)
7b36f2c 
<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #1559
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Exclude virtual modules by default (anuclim, icclim, cf), add checkbox
to include them
* Even when virtual modules are included, boost "official" indicators in
the results.

I bumped the MiniSearch version to be able to use the "wildcard" option,
which cover the case where no search query is given. This way, the
boosting official indicators is done even with an empty query.

### Does this PR introduce a breaking change?
No.

### Other information:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
xclim Documentation Overhaul
Status: Done
Milestone
v0.48.0
Development

Successfully merging a pull request may close this issue.

Better indicators search Ouranosinc/xclim
2 participants
@huard @aulemahal