Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better indicators search #1593

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Better indicators search #1593

merged 3 commits into from
Jan 15, 2024

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Jan 12, 2024 •
edited by Zeitsperre
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Exclude virtual modules by default (anuclim, icclim, cf), add checkbox to include them
  • Even when virtual modules are included, boost "official" indicators in the results.

I bumped the MiniSearch version to be able to use the "wildcard" option, which cover the case where no search query is given. This way, the boosting official indicators is done even with an empty query.

Does this PR introduce a breaking change?

No.

Other information:

@aulemahal aulemahal requested a review from Zeitsperre January 12, 2024 21:30
@github-actions github-actions bot added the docs Improvements to documenation label Jan 12, 2024
Zeitsperre
Zeitsperre approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@github-actions github-actions bot added the approved Approved for additional tests label Jan 15, 2024
@coveralls
Copy link

Coverage Status

coverage: 90.273%. first build
when pulling bbaa657 on fix-1559
into bcec43e on master.

@aulemahal aulemahal merged commit 7b36f2c into master Jan 15, 2024
16 checks passed
@aulemahal aulemahal deleted the fix-1559 branch January 15, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better search results
3 participants
@aulemahal @coveralls @Zeitsperre