Labeling fixes, Use Concurrency to cancel workflows (#1487)

### What kind of change does this PR introduce?

* Fixes a bug that was recognizing all PRs as though they were coming
from forks of Ouranosinc/xclim
* Removes credentials from the actions-version-updater.yml so that I
don't get the commit credit (and cannot approve the resulting PR)
* Replace the styfle/cancel-workflow-action with concurrency

.github/workflows/actions-versions-updater.yml

@@ -14,6 +14,7 @@ jobs:
       - uses: actions/[email protected]
         with:
           token: ${{ secrets.WORKFLOW_TOKEN }}
+          persist-credentials: false
       - name: Run GitHub Actions Version Updater
         uses: saadmk11/[email protected]
         with:

.github/workflows/label_on_approval.yml

@@ -37,7 +37,7 @@ jobs:
   comment_approved:
     name: Comment Concerning Approved Tag
     if: |
-      (github.event_name == 'pull_request_target') ||
+      (github.event_name == 'pull_request_target') &&
       (github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name)
     runs-on: ubuntu-latest
     steps:
@@ -50,8 +50,9 @@ jobs:
           body-includes: This Pull Request is coming from a fork and must be manually tagged `approved` in order to perform additional testing
       - name: Create comment
         if: |
-          (steps.fc.outputs.comment-id == '') ||
-          (!contains(github.event.pull_request.labels.*.name, 'approved'))
+          (steps.fc.outputs.comment-id == '') &&
+          (!contains(github.event.pull_request.labels.*.name, 'approved')) &&
+          (github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name)
         uses: peter-evans/[email protected]
         with:
           comment-id: ${{ steps.fc.outputs.comment-id }}
@@ -68,7 +69,8 @@ jobs:
           comment-id: ${{ steps.fc.outputs.comment-id }}
           issue-number: ${{ github.event.pull_request.number }}
           body: |
-            Pull Request is approved!
+            > **Note**
+            > This Pull Request is approved!
           reactions: |
             hooray
           edit-mode: append

.github/workflows/main.yml

@@ -22,6 +22,11 @@ on:
 env:
   XCLIM_TESTDATA_BRANCH: v2023.9.12
 
+concurrency:
+  # For a given workflow, if we push to the same branch, cancel all previous builds on that branch except on master.
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
+
 jobs:
   lint:
     name: Black (Python${{ matrix.python-version }})
@@ -35,10 +40,6 @@ jobs:
         python-version:
           - "3.8"
     steps:
-      - name: Cancel previous runs
-        uses: styfle/[email protected]
-        with:
-          access_token: ${{ github.token }}
       - uses: actions/[email protected]
       - name: Set up Python${{ matrix.python-version }}
         uses: actions/[email protected]

.github/workflows/publish-mastodon.template.md

@@ -1,4 +1,4 @@
-New #xclim release: v{{ .version }} 🎉
+New #xclim release: {{ .version }} 🎉
 
 Latest source code available at: https://github.com/Ouranosinc/xclim/releases/tag/{{ .version }}
 Check out the docs for more information: https://xclim.readthedocs.io/en/stable/

.github/workflows/publish-mastodon.yml

@@ -16,7 +16,7 @@ on:
         type: boolean
 
 jobs:
-  build:
+  toot:
     runs-on: ubuntu-latest
     environment: production
     steps:

CHANGES.rst

@@ -36,7 +36,7 @@ Internal changes
 * Changes to the ``.zenodo.json`` file no longer are marked as CI-related changes. (:pull:`1479`).
 * GitHub deployment workflows now employs use of deployment environments for workflow security and uses the `Trusted Publisher <https://docs.pypi.org/trusted-publishers/using-a-publisher/>`_ feature to sign and publish the `xclim` wheel and source distributions. (:pull:`1469`).
 * Mastodon publishing now uses `chuhlomin/render-template <https://github.com/chuhlomin/render-template>`_ and a standard formatting markdown document to format Mastodon toots. (:pull:`1469`).
-
+* GitHub testing workflows now use `Concurrency` instead of the styfle/cancel-workflow-action to cancel redundant workflows. (:pull:`1487`).
 
 v0.45.0 (2023-09-05)
 --------------------