fix edge case where auth state is left behind in an updated instance #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this PR mark as "fixes bird-house/birdhouse-deploy#443"? |
I'll resolve that issue once the jupyterhub version has been updated on the birdhouse-deploy repo |
mishaschwartz
added a commit
to bird-house/birdhouse-deploy
that referenced
this pull request
Apr 9, 2024
## Overview If the `JUPYTERHUB_AUTHENTICATOR_AUTHORIZATION_URL` variable or `JUPYTERHUB_CRYPT_KEY` is unset without clearing the jupyterhub database, users could no longer spawn jupyterlab servers. ## Changes **Non-breaking changes** - New component version jupyterhub:4.1.4-20240408 ## Related Issue / Discussion - Resolves #443 ## Additional Information Links to other issues or sources. Related to: Ouranosinc/jupyterhub#30 ## CI Operations <!-- The test suite can be run using a different DACCS config with ``birdhouse_daccs_configs_branch: branch_name`` in the PR description. To globally skip the test suite regardless of the commit message use ``birdhouse_skip_ci`` set to ``true`` in the PR description. Note that using ``[skip ci]``, ``[ci skip]`` or ``[no ci]`` in the commit message will override ``birdhouse_skip_ci`` from the PR description. --> birdhouse_daccs_configs_branch: master birdhouse_skip_ci: false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
authorization_urlandenable_auth_statevalues were previously set, then later one or both are unset, jupyterhub is restarted, and the database is not cleared, there will be anauth_statepresent for users who previously logged in stored in the database.In this case, jupyterhub will still attempt to update the
auth_statewith a now invalidauthorization_url. This adds additional checks to ensure that this will not attempt to update theauth_statewith invalid settings.