Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for e2e tests #47

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Fix for e2e tests #47

merged 8 commits into from
Nov 16, 2023

Conversation

ChaamC
Copy link
Contributor

@ChaamC ChaamC commented Nov 15, 2023

Fixes some bugs found while implementing the e2e test that checks Cowbird and Jupyter usage on birdhouse (see PRs #131 and #404):

  • The FileSystem handler now creates the WPS outputs data folder if it doesn't exist so that monitoring is setup
    properly.
  • User permissions are set explicitly after creating his datastore folder to make sure the user can create and modify
    files in it.

@ChaamC ChaamC self-assigned this Nov 15, 2023
@github-actions github-actions bot added the doc Updates to documentation. label Nov 15, 2023
@ChaamC ChaamC requested a review from fmigneault November 15, 2023 16:51
fmigneault
fmigneault previously approved these changes Nov 16, 2023
@github-actions github-actions bot added the ci Updates to the CI pipelines and related utilities. label Nov 16, 2023
@github-actions github-actions bot added the tests Modifications to tests or problems related to test suite. label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4a5e77d) 87.57% compared to head (2fe10b3) 87.71%.
Report is 2 commits behind head on master.

Files Patch % Lines
cowbird/handlers/impl/geoserver.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   87.57%   87.71%   +0.14%     
==========================================
  Files          40       40              
  Lines        3211     3216       +5     
  Branches      471      471              
==========================================
+ Hits         2812     2821       +9     
+ Misses        278      276       -2     
+ Partials      121      119       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChaamC ChaamC requested a review from fmigneault November 16, 2023 14:40
@ChaamC
Copy link
Contributor Author

ChaamC commented Nov 16, 2023

@fmigneault Fixed some check and test errors, need reapproval before I can merge.

@ChaamC ChaamC merged commit 25e7eae into master Nov 16, 2023
20 of 21 checks passed
@ChaamC ChaamC deleted the fix-for-e2e-tests branch November 16, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Updates to the CI pipelines and related utilities. doc Updates to documentation. tests Modifications to tests or problems related to test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants