-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for e2e tests #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
previously approved these changes
Nov 16, 2023
github-actions
bot
added
the
ci
Updates to the CI pipelines and related utilities.
label
Nov 16, 2023
github-actions
bot
added
the
tests
Modifications to tests or problems related to test suite.
label
Nov 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 87.57% 87.71% +0.14%
==========================================
Files 40 40
Lines 3211 3216 +5
Branches 471 471
==========================================
+ Hits 2812 2821 +9
+ Misses 278 276 -2
+ Partials 121 119 -2 ☔ View full report in Codecov by Sentry. |
@fmigneault Fixed some check and test errors, need reapproval before I can merge. |
fmigneault
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bugs found while implementing the e2e test that checks Cowbird and Jupyter usage on birdhouse (see PRs #131 and #404):
FileSystem
handler now creates the WPS outputs data folder if it doesn't exist so that monitoring is setupproperly.
files in it.