Skip to content

Commit

Permalink
clarify doc about wps outputs permissions without the secure-data-pro…
Browse files Browse the repository at this point in the history
…xy service
  • Loading branch information
cwcummings committed Nov 14, 2023
1 parent e019d12 commit b76f7f1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cowbird/handlers/impl/filesystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ def _create_wps_outputs_hardlink(self, src_path: str, overwrite: bool = False,
subpath=regex_match.group("subpath"))
api_services = magpie_handler.get_services_by_type(ServiceAPI.service_type)
if self.secure_data_proxy_name not in api_services:
LOGGER.warning("`%s` service not found. Considering user WPS outputs data as accessible by default.",
self.secure_data_proxy_name)
LOGGER.warning("`%s` service not found. Considering user WPS outputs data as accessible (read-only) "
"by default.", self.secure_data_proxy_name)
apply_new_path_permissions(src_path, True, False, False)
else: # get access and apply permissions if the secure-data-proxy exists
access_allowed = self.update_secure_data_proxy_path_perms(src_path, user_name)
Expand Down
4 changes: 2 additions & 2 deletions docs/components.rst
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ If the file does not have any read or write permissions, the hardlink will not b
Refer to `DAC-571 <https://crim-ca.atlassian.net/browse/DAC-571>`_ for more details on the design choices for the
management of permissions.

If no ``secure-data-proxy`` service is found, the user files are assumed to be fully available
with read and write permissions for the user.
If no ``secure-data-proxy`` service is found, all user files are assumed to be available with read permissions for
the user.

Note that different design choices were made to respect the constraints of the file system and to prevent the user from
accessing forbidden data:
Expand Down

0 comments on commit b76f7f1

Please sign in to comment.