fix(sonar): correct sonar issues

Ouest-France · Nov 15, 2023 · 870b907 · 870b907
1 parent f73f0c5
commit 870b907
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/main/java/fr/ouestfrance/querydsl/service/validators/FilterFieldConstraintException.java b/src/main/java/fr/ouestfrance/querydsl/service/validators/FilterFieldConstraintException.java
@@ -13,7 +13,7 @@ public class FilterFieldConstraintException extends RuntimeException {
     /**
      * List of violations
      */
-    private final List<FilterFieldViolation> violations;
+    private final transient List<FilterFieldViolation> violations;
     /**
      * Class of the bean scanned
      */

diff --git a/src/test/java/fr/ouestfrance/querydsl/dummy/DummyRequest.java b/src/test/java/fr/ouestfrance/querydsl/dummy/DummyRequest.java
@@ -27,4 +27,7 @@ public class DummyRequest {
 
     @FilterField
     private boolean valid;
+
+    private String noFilterField;
 }
+
diff --git a/src/test/java/fr/ouestfrance/querydsl/service/ext/QueryDslProcessorServiceTest.java b/src/test/java/fr/ouestfrance/querydsl/service/ext/QueryDslProcessorServiceTest.java
@@ -32,8 +32,13 @@ void shouldTranslate() {
         object.setValidityDate(LocalDate.of(2023, 12, 12));
         object.setValid(true);
         List<String> translate = translatorService.process(object);
-        System.out.println(translate);
         assertEquals(4, translate.size());
         assertLinesMatch(List.of("productCode=25", "startDate=2023-12-12", "endDate=2023-12-12", "valid=true"), translate);
     }
+
+    @Test
+    void shouldTranslateWithNullValue() {
+        List<String> translate = translatorService.process(null);
+        assertEquals(0, translate.size());
+    }
 }