remove test implementations that don't actually test the described fe…

…ature `fetch` API doesn't allow sending a body with GET requests
OtterJS · Sep 22, 2024 · d37e626 · d37e626
1 parent 65e64c8
commit d37e626
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 61 deletions.
diff --git a/tests/custom.test.ts b/tests/custom.test.ts
@@ -25,20 +25,6 @@ test('should parse custom body', async () => {
   }).expect(200, 'HELLO WORLD')
 })
 
-test('custom should ignore GET request', async () => {
-  const server = createServer(async (req: Request, res) => {
-    const body = await custom(req, res)
-
-    res.setHeader('Content-Type', 'text/plain')
-
-    res.end(body == null ? 'GET is ignored' : 'GET is not ignored')
-  })
+test.skip('custom should ignore GET request', async () => {
 
-  await makeFetch(server)('/', {
-    method: 'GET',
-    headers: {
-      Accept: 'text/plain',
-      'Content-Type': 'text/plain',
-    },
-  }).expect(200, 'GET is ignored')
 })
diff --git a/tests/json.test.ts b/tests/json.test.ts
@@ -108,13 +108,8 @@ it('should not parse json body with no content-type headers', async () => {
   await expect(response.text()).resolves.toEqual('')
 })
 
-it('should ignore GET requests', async () => {
-  const fetch = createFetch()
-  const response = await fetch({
-    method: 'GET',
-  })
-  expect(response.status).toBe(200)
-  await expect(response.text()).resolves.toEqual('')
+it.skip('should ignore GET requests', async () => {
+
 })
 
 describe('with invalid JSON body', () => {

diff --git a/tests/raw.test.ts b/tests/raw.test.ts
@@ -25,20 +25,6 @@ test('should parse raw body', async () => {
   }).expect(200, 'hello world')
 })
 
-test('raw should ignore GET request', async () => {
-  const server = createServer(async (req: Request, res) => {
-    const body = await raw(req, res)
-
-    res.setHeader('Content-Type', 'text/plain')
-
-    res.end('GET is ignored')
-  })
+test.skip('raw should ignore GET request', async () => {
 
-  await makeFetch(server)('/', {
-    method: 'GET',
-    headers: {
-      Accept: 'text/plain',
-      'Content-Type': 'text/plain',
-    },
-  }).expect(200, 'GET is ignored')
 })
diff --git a/tests/text.test.ts b/tests/text.test.ts
@@ -25,20 +25,6 @@ test('should parse text body', async () => {
   }).expect(200, 'hello world')
 })
 
-test('text should ignore GET request', async () => {
-  const server = createServer(async (req: Request, res) => {
-    await text(req, res)
-
-    res.setHeader('Content-Type', 'text/plain')
-
-    res.end('GET is ignored')
-  })
+test.skip('text should ignore GET request', async () => {
 
-  await makeFetch(server)('/', {
-    method: 'GET',
-    headers: {
-      Accept: 'text/plain',
-      'Content-Type': 'text/plain',
-    },
-  }).expect(200, 'GET is ignored')
 })
diff --git a/tests/urlencoded.test.ts b/tests/urlencoded.test.ts
@@ -25,14 +25,6 @@ test('should parse urlencoded body', async () => {
   }).expect(200, { hello: 'world' })
 })
 
-test('urlencoded should ignore GET request', async () => {
-  const server = createServer(async (req: Request, res) => {
-    const body = await urlencoded(req, res)
+test.skip('urlencoded should ignore GET request', async () => {
 
-    res.end('GET is ignored')
-  })
-
-  await makeFetch(server)('/', {
-    method: 'GET',
-  }).expect(200, 'GET is ignored')
 })