SaveInformation::canSave is not required #1619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fnkkio, perhaps it was unfinished, what about turning it into helper method instead? |
I'm sorry but what do you mean about helper method ? It is already in the Utils namespace. |
|
@fnkkio, helper method in |
|
@Emdek Added helper method. |
|
@fnkkio, yeah, I meant adding it and using it. :-D I kind of expected that you would keep the same name ( |
fnkkio
force-pushed
the
fixes/fix_utils_getsavepath
branch
from
dc1e2e9
to
e7f602b
Compare
|
@Emdek Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case Utils::getSavePath is called with valid fileName and directory, SaveInformation::canSave would never be set to true; moreover, this data member is not required since we can just return an empty SaveInformation::path in case we didn't get a valid save path.