Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted codebase to typescript and background page/worker #174

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

mocanew
Copy link
Contributor

@mocanew mocanew commented Nov 2, 2023

Fixes #108, #172

Using a background page/worker boosts perceived performance a lot compared to the current way of interacting with sync storage (all actions are now instant).

Improved perceived extension load speed when first opening YouTube: buttons are added as soon as possible rather than checking for page elements.


The extension now needs two zip files, one for firefox and one for chrome, due to manifest v2 and v3 incompatibilities (background script vs service worker - firefox doesn't yet support service workers).


In order for Reviewdog to post comments with PR's linting errors, REVIEWDOG_TOKEN secret needs to be set. To get the token:

  1. Install (authorize) https://github.com/apps/reviewdog for this repo
  2. Log in to https://reviewdog.app/
  3. Get token from https://reviewdog.app/gh/OsaSoft/youtube-better-subscriptions
  4. Set REVIEWDOG_TOKEN in github repo's secrets

@mocanew mocanew marked this pull request as ready for review November 18, 2023 11:28
@mocanew
Copy link
Contributor Author

mocanew commented Nov 18, 2023

@OsaSoft this PR is ready, have a look at it when you have some free time.

@tummyslyunopened
Copy link

@OsaSoft @mocanew Is the plan still to convert to TS / implement these changes. I have been using this extension a lot recently and have contributions ready for a few issues, but would like to know if this is welcome / should new contributers wait until TS is adopted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite into TS
2 participants