-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted codebase to typescript and background page/worker #174
Open
mocanew
wants to merge
26
commits into
OsaSoft:master
Choose a base branch
from
mocanew:feature/typescript-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108, #172
Using a background page/worker boosts perceived performance a lot compared to the current way of interacting with sync storage (all actions are now instant).
Improved perceived extension load speed when first opening YouTube: buttons are added as soon as possible rather than checking for page elements.
The extension now needs two zip files, one for firefox and one for chrome, due to manifest v2 and v3 incompatibilities (background script vs service worker - firefox doesn't yet support service workers).
In order for Reviewdog to post comments with PR's linting errors,
REVIEWDOG_TOKEN
secret needs to be set. To get the token:REVIEWDOG_TOKEN
in github repo's secrets