Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@devjunr - Resolução Desafio 2 #1093

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Conversation

devJunr
Copy link
Contributor

@devJunr devJunr commented Oct 14, 2024

No description provided.

Copy link

@magnussolidus magnussolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por favor, dê uma conferida nos detalhes da ação.
A estrutura está errada: a validação é case sensitive, Java e java são coisas distintas para ele.
O correto é java, tudo em minúsculo.

@magnussolidus magnussolidus self-requested a review October 14, 2024 13:21
Copy link

@magnussolidus magnussolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A indentação está errada (tem espaços extras). Dá uma conferida na saída do pipeline que você perceberá o problema.

@magnussolidus magnussolidus added the java Pull requests that update Java code label Oct 14, 2024
@marcopaganini
Copy link
Contributor

O código continua com problemas de indentação. Tudo com um "-" na frente tem que sair e tudo com um "+" tem que entrar. Voce pode observar que o código é identico, mas está faltando um nível de indentação no seu código.

@magnussolidus magnussolidus requested review from magnussolidus and removed request for magnussolidus October 19, 2024 08:41
Copy link

@magnussolidus magnussolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comentando para não ficar travando um merge.

@magnussolidus magnussolidus self-requested a review October 19, 2024 08:42
@marcopaganini marcopaganini dismissed magnussolidus’s stale review October 21, 2024 01:44

Consertado em commit posterior.

@marcopaganini marcopaganini merged commit 7a8ac19 into OsProgramadores:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants