Detailed tracking status for SOLR Tracking page. #206
Conversation
| var getMethod = | ||
| new Packages.org.apache.commons.httpclient.methods.GetMethod( | ||
| solrHttpClientFactory.getHttpClient().getHostConfiguration().getHostURL() + | ||
| '/solr/' + coreNames[i] + '/select?' + |
There was a problem hiding this comment.
The /solr part should probably be changed to respect the solr.baseUrl config property, in case SOLR has been deployed on a different context.
There was a problem hiding this comment.
We were discussing this on Discord as well, and a point of general concern is the raw use of the HTTP client here. For one there is the issue about the base URL config potentially not accessible in the global properties (accessible only IF explicitly specified in alfresco-global.properties as an override to default subsystem properties, NOT if defined via "clean" subsystem config or env variable override). Another issue is the repeated construction of a HTTP client from the factory for each invocation, as well as the lack of try-finally dealing with the proper consumption and closure of the response entity (indirectly linked to the release of underlying HTTP connections in the HTTP client library) even in exceptional cases.
Since we can rely on the Search subsystem to be available in all Alfresco versions, it would be acceptable to add a custom Java-based helper bean into the subsystem context and expose that via a proxy bean. Any SOLR subsystem version that would not support the relevant call could be covered with a no-op default bean via the proxy. In the ideal case, we would not expose the raw JSON result, but a parsed version of it via a DTO. This might even allow any contributor / user who is interested to potentially add support for older SOLR versions i.e. in case they intend to run OOTBee Support Tools on ACS 5.x with SOLR 4. For this PR it is perfectly fine to focus on ASS 1.x/2.x and SOLR 6 exclusively.
|
I can definitely add the German translation and also do any adjustments needed to comply with our JS code style. |
|
Due to the focus on the log4j issue and limited personal (time) resources, I did miss re-reviewing this, coordinating missing translations, and tests on multiple ACS versions for the 1.2.1.0 release. I have now marked this for the 1.3.0.0 milestone so that it will at least come up when eventually preparing that release. |
Still missng German and Portuguese resources.
AFaust
force-pushed
the
feature/search-details
branch
from
49cd579 to
2fbbe54
Compare
|
I took the liberty of rebasing the branch to the latest master of OOTBee Support Tools. |
|
I have done a bit of work on the PR and added German labels, but also altered a bit of the structure (using more specific titles for the detail section + removed redundant tx remaining info). |
Still missng German and Portuguese resources.
Adding Tracking details for SOLR Tracking web page.