Add copy-to-clipboard action for thread dumps #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binduwavell
approved these changes
May 11, 2020
| area.value = textToWrite; | ||
| document.body.appendChild(area); | ||
| area.select(); | ||
| document.execCommand('copy'); |
There was a problem hiding this comment.
Does this approach work in all modern browsers? Last I checked, this would not work in Chrome.
There was a problem hiding this comment.
Honestly, did not actually check other browsers apart from Firefox, which I should have done and will do.
There was a problem hiding this comment.
Tested on Windows 10 with IE 11.778.18362.0, Firefox 76.0.1, Edge 44, Chrome 81.0.4044.138 - copy to clipboard works in all environments, although IE 11 needs a bit of a fixup with regards to stripping HTML markup out of before copying to clipboard.
AFaust
force-pushed
the
threadDump-copyToClipboard
branch
from
3ee462c to
5d7eb6c
Compare
AFaust
force-pushed
the
threadDump-copyToClipboard
branch
from
5d7eb6c to
b731a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHECKLIST
We will not consider a PR until the following items are checked off--thank you!
CONVINCING DESCRIPTION
This PR adds a copy-to-clipboard action to the thread dump tooling to make it easier to take the thread dump and put it into some external thread dump analysis tooling, like the Spotify Thread Dump Analyser
RELATED INFORMATION
This PR does not fix a specific issue, but might be able to help support the use case expressed in #141